Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add final for readData methods #346

Merged
merged 1 commit into from
Dec 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1925,7 +1925,7 @@ public long fileSize() throws IOException {
* @param totalSize the size of data that want to read
* @return data that been read.
*/
protected ByteBuffer readData(long position, int totalSize) throws IOException {
protected final ByteBuffer readData(long position, int totalSize) throws IOException {
return readData(position, totalSize, null);
}

Expand Down Expand Up @@ -1986,7 +1986,7 @@ protected ByteBuffer readData(long position, int totalSize, LongConsumer ioSizeR
* @param end the end position of data that want to read
* @return data that been read.
*/
protected ByteBuffer readData(long start, long end) throws IOException {
protected final ByteBuffer readData(long start, long end) throws IOException {
return readData(start, end, null);
}

Expand All @@ -2000,7 +2000,7 @@ protected ByteBuffer readData(long start, long end) throws IOException {
* @param ioSizeRecorder can be null
* @return data that been read.
*/
protected ByteBuffer readData(long start, long end, LongConsumer ioSizeRecorder)
protected final ByteBuffer readData(long start, long end, LongConsumer ioSizeRecorder)
throws IOException {
try {
return readData(start, (int) (end - start), ioSizeRecorder);
Expand Down
Loading