Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate header file dependencies for test and src. #364

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

ColinLeeo
Copy link
Contributor

@ColinLeeo ColinLeeo commented Jan 5, 2025

In this pr:

  1. The test code now fully relies on the installed header files from the source code rather than the source code itself, separating the outputs of the source code and test code.
  2. Removed unused code.
  3. Saved the gtest code locally, eliminating the need for remote fetching.

cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/cmake/CopyToDIr.cmake Outdated Show resolved Hide resolved
cpp/test/CMakeLists.txt Outdated Show resolved Hide resolved
@ColinLeeo
Copy link
Contributor Author

ColinLeeo commented Jan 20, 2025

Well.. This PR introduces changes that may encounter issues in the Windows environment. Using the shared library form causes exceptions during test linking, and despite numerous attempts, the problem remains unresolved. To fix them, currently, the tests are linked to TsFile using the static linking approach. Additionally, on Windows devices, std::random_device rd; does not return random values. As a result, I have modified some test methods for obtaining random seeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants