-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter #4443
base: master
Are you sure you want to change the base?
Conversation
livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java
Outdated
Show resolved
Hide resolved
livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java
Outdated
Show resolved
Hide resolved
livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java
Outdated
Show resolved
Hide resolved
livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java
Outdated
Show resolved
Hide resolved
livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java
Outdated
Show resolved
Hide resolved
I have found a new bug in this file. message data like this will fail with exception
which is caused by code in this place I will fix this later. |
ping @zkytech |
What should I do next? |
@zkytech Have you resolved the issue in the above comment ?#4443 (comment) |
Yes, It has been fixed in this commit c31945d The url in commit message is wrong, it should be https://github.com/apache/zeppelin/pull/4443#issuecomment-1214710538, |
Sorry for late response @zkytech Could you retrigger the CI? |
ok |
@zkytech livy interpreter in CI is failed, could help fix it? LivySparkSQLInterpreter |
@zjffdu fixed |
Please rebase your PR to current master. |
@Reamer Done |
Let's wait for CI tests |
Unit test is required to update. Because JSON number is no longer treat as string in this place |
Add test case for multi level json string
@zjffdu To fix this bug, I have made a change in this place, JSON number is no longer treat as string . Since JSON doesn't distinguish between integer and floating point fields, I have made a change to unit test, all number in json will be convert to float value. |
What is this PR for?
What type of PR is it?
Feature & Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5798
How should this be tested?
execute multiline sql statement with ";", for example:
Questions: