Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(laravel): add support for backed enums #6911

Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat(laravel): add support for backed enums #6911

merged 1 commit into from
Jan 13, 2025

Conversation

toitzi
Copy link
Contributor

@toitzi toitzi commented Jan 10, 2025 •
edited
Loading

Closes: #6906

Q A
Branch? 4.1
Tickets Closes #6906
License MIT
Doc PR -

@toitzi toitzi changed the title feat(laravel): add support for backed enum normalizers feat(laravel): add support for backed enums Jan 10, 2025
@toitzi
Copy link
Contributor Author

toitzi commented Jan 10, 2025

I still have to write a unittest, but checks are failing because boolean filter got accidently removed see here

I don't want to change it to avoid giving unnecessary merge conflicts.

@soyuka
Copy link
Member

soyuka commented Jan 13, 2025

Can we target 4.0 ? I'd consider features that are available with Symfony bug fixes for Laravel. Thanks!

@vinceAmstoutz
Copy link
Contributor

I still have to write a unittest, but checks are failing because boolean filter got accidently removed see here

I don't want to change it to avoid giving unnecessary merge conflicts.

@toitzi After targeting 4.0, as Soyuka asked you previously, (and optionally rebase) you should not have this issue again

@toitzi toitzi force-pushed the toitzi/backed_enum branch from 0c05fce to 0ffc7a3 Compare January 13, 2025 10:33
@toitzi toitzi changed the base branch from 4.1 to 4.0 January 13, 2025 10:33
@toitzi toitzi force-pushed the toitzi/backed_enum branch 2 times, most recently from d4485fa to 3d8fa31 Compare January 13, 2025 10:50
@toitzi toitzi marked this pull request as ready for review January 13, 2025 10:51
@toitzi toitzi force-pushed the toitzi/backed_enum branch from 3d8fa31 to a37b3ba Compare January 13, 2025 10:53
@toitzi
Copy link
Contributor Author

toitzi commented Jan 13, 2025

@soyuka added unittest, targeting branch 4.0 now
@vinceAmstoutz works, thanks!

@soyuka soyuka merged commit 421d97e into api-platform:4.0 Jan 13, 2025
59 checks passed
@soyuka
Copy link
Member

soyuka commented Jan 13, 2025

amazing many thanks @toitzi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinceAmstoutz vinceAmstoutz vinceAmstoutz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toitzi @soyuka @vinceAmstoutz