Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openapi): document error outputs using json-schemas #6923

Open
wants to merge 1 commit into
base: 4.0
Choose a base branch
from

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Jan 20, 2025

Q A
Branch? not sure yet
Tickets Closes #6918
License MIT
Doc PR n/a

This fixes many issues related to how errors and constraint violations are documented, it was reported in #6918 and is a follow up of #6748 (therefore I'd be up to add this on 4.1 instead of 4.0 as without the patch there are still inconsistencies).

A few screenshots:

20250120_16h42m54s_grim
20250120_16h42m48s_grim
20250120_16h42m36s_grim

I still need to add a few tests as this was hard to implement we need to cover regressions...

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants