Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix cross-package version dependencies #6935

Merged
merged 3 commits into from
Jan 31, 2025
Merged

fix: Fix cross-package version dependencies #6935

merged 3 commits into from
Jan 31, 2025

Conversation

GromNaN
Copy link
Contributor

@GromNaN GromNaN commented Jan 30, 2025 •
edited
Loading

Q A
Branch? 4.1
Tickets -
License MIT
Doc PR -

Doctrine

#6775 introduced a new interface ApiPlatform\Doctrine\Common\Filter\ManagerRegistryAwareInterface that is implemented by ApiPlatform\Doctrine\{Orm,Odm}\Filter\AbstractFilter, making api-platform/doctrine-{orm,odm}: 4.1 require api-platform/doctrine-common: 4.1.

I hit this error while requiring only the dev version of api-platform/doctrine-odm.

!!    Invalid service "api_platform.doctrine_mongodb.odm.search_filter": class "A  
!!    piPlatform\Doctrine\Common\Filter\ManagerRegistryAwareInterface" not found   
!!    while loading "ApiPlatform\Doctrine\Odm\Filter\SearchFilter".

Symfony Bundle

#6877 added OpenApi::hasPersistAuthorization() used by SwaggerUiAction.

Validator

#6748 made attribute ApiProperty repeatable, used multiple times by ValidationException.

@GromNaN GromNaN force-pushed the doctrine-common-version branch from 8c5348b to 8bd0622 Compare January 30, 2025 09:38
@GromNaN GromNaN changed the title Fix required version of api-platform/doctrine-common by ORM and ODM packages chore(doctrine): Fix required version of api-platform/doctrine-common by ORM and ODM packages Jan 30, 2025
@GromNaN GromNaN changed the title chore(doctrine): Fix required version of api-platform/doctrine-common by ORM and ODM packages fix(doctrine): Fix required version of api-platform/doctrine-common by ORM and ODM packages Jan 30, 2025
@GromNaN GromNaN force-pushed the doctrine-common-version branch from 8bd0622 to ffbd930 Compare January 30, 2025 09:41
@GromNaN GromNaN changed the title fix(doctrine): Fix required version of api-platform/doctrine-common by ORM and ODM packages fix: Fix cross-package version dependencies Jan 30, 2025
@GromNaN GromNaN force-pushed the doctrine-common-version branch from 2f92d86 to 6a39599 Compare January 30, 2025 16:08
@GromNaN
fix(doctrine): fix required version of doctrine-common
b3e75ea 
interface ManagerRegistryAwareInterface implemeted by ApiPlatform\Doctrine\{Orm,Odm}\Filter\AbstractFilter

api-platform#6775
@GromNaN
symfony package requires openapi 4.1
48ff963 
Method OpenApi::hasPersistAuthorization() used by SwaggerUiAction

api-platform#6877
@GromNaN
validator package requires metadata 4.1
d6f68e5 
Attribute ApiProperty used multiple times by ValidationException

api-platform#6748
@GromNaN GromNaN force-pushed the doctrine-common-version branch from 6a39599 to d6f68e5 Compare January 30, 2025 16:10
@soyuka soyuka merged commit 562ddd3 into api-platform:4.1 Jan 31, 2025
59 checks passed
@soyuka
Copy link
Member

soyuka commented Jan 31, 2025

thanks @GromNaN !

@GromNaN GromNaN deleted the doctrine-common-version branch January 31, 2025 14:02
jonerickson pushed a commit to jonerickson/core that referenced this pull request Feb 5, 2025
@GromNaN @jonerickson
chore: cross-package version dependencies (api-platform#6935)
804759a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GromNaN @soyuka @dunglas