Add status codes to test ID and Dredd output

[anth0d]

🚀 Why this change?

The primary reason for this change is that test IDs are non-unique and that makes test output hard to understand. This PR adds the (###) to the transaction ID so that a 200 is distinctly different from a 204, 401, 404, etc...

info: Successfully connected to hooks handler. Waiting 0.1s to start testing.
pass: POST (204) /channelmapper/v1/channel duration: 25ms
skip: POST (401) /channelmapper/v1/channel
skip: POST (404) /channelmapper/v1/channel
pass: GET (200) /v1/channel/9cd4342be duration: 25ms
skip: GET (401) /v1/channel/9cd4342be
pass: GET (404) /v1/channel/9cd4342be duration: 16ms

complete: 3 passing, 0 failing, 0 errors, 3 skipped, 6 total

📝 Related issues and Pull Requests

• Closes Transaction ids are not unique and do not include expected status code #866

✅ What didn't I forget?

• [✔] To write docs
• [✔] To write tests
• [✔] To put Conventional Changelog prefixes in front of all my commits and run npm run lint

[honzajavorek]

Thanks for the PR! I think this is generally a good idea. See my comments.

The current format of the transaction ID is part of many tests, so those will need to be changed first. That's why tests on both Windows (AppVeyor) and Linux (Travis CI) failed.

I also suggest to update the example value for the transaction ID in Dredd's docs: https://dredd.readthedocs.io/en/latest/data-structures.html#transaction-object

[honzajavorek]

I was reading #867 before this one, hence my comment there. The only important part is that I'd suggest the name of the command to be build:watch instead of watch.

[honzajavorek]

Why this change?

[anth0d]

Sorry I thought I linked the issue. Currently the latest version of dredd-transactions has an issue introduced by one of its dependencies - apiaryio/dredd-transactions#93

[honzajavorek]

Yes, but that's better solved by releasing a fix. One fix is already out, the other one will follow shortly.

…

On 18 Aug 2017, 17:03 +0200, Anthony Davis ***@***.***>, wrote: @antkazam commented on this pull request. In package.json: > @@ -35,7 +36,7 @@ "coffee-script": "^1.12.5", "colors": "^1.1.2", "cross-spawn": "^5.0.1", - "dredd-transactions": "^4.3.0", + "dredd-transactions": "4.2.0", Sorry I thought I linked the issue. Currently the latest version of dredd-transactions has an issue introduced by one of its dependencies - apiaryio/dredd-transactions#93 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[anth0d]

@honzajavorek I've made the changes you requested - but unfortunately the Travis CI build failed - I am trying to reproduce but having no success. The failing tests are here and here if you have any tips for how to debug.

[honzajavorek]

@antkazam I see all builds passing on the last commit. I guess you figured it out then? I'll get back shortly to do review.

[honzajavorek]

Just a nitpick from looking at the commits, you may want to fix your git or GitHub email settings to have your authorship correctly associated:

Only noting for your own good, this by no means blocks the PR.

[honzajavorek]

Looks great! 👍 Thanks so much! ✨

I'm ready to merge this. I'll give you some time to figure out the email associations if you want (if you want to amend the previous commits and to change their email, you may want to rebase the branch before it gets merged) and possibly tomorrow I think I'll merge this 🚀

[honzajavorek]

This needs to wait until #872 gets fixed. We need to release a fix in patch so it auto-propagates to installations the same way as did the bug. Adding a feature would close the way to auto-propagate by bumping the minor version number.

[anth0d]

Thanks @honzajavorek I was out of town until now. Really appreciate your help.

[honzajavorek]

@antkazam Thanks for the PR! 👍