Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install apify dependencies in the Dockerfile #227

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Nov 16, 2023

The wrapper requirements file got renamed, so the docker build will fail in projects without their own requirements.txt.

While this is still not 100%, I guess it's safer to preinstall our deps and let the user modify the Dockerfile for their (custom) dependency installation.

The wrapper requirements file got renamed, so the docker build will fail in projects without their own `requirements.txt`. 

While this is still not 100%, I guess it's safer to preinstall our deps and let the user modify the Dockerfile for their (custom) dependency installation.
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Nov 16, 2023
@barjin barjin requested a review from vdusek November 16, 2023 13:25
@barjin barjin self-assigned this Nov 16, 2023
@github-actions github-actions bot added this to the 76th sprint - Tooling team milestone Nov 16, 2023
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 16, 2023
@barjin barjin merged commit 351b1b9 into master Nov 16, 2023
@barjin barjin deleted the fix/wrapper-deps-install branch November 16, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant