-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support use_incognito_pages
for browser_launch_options
in PlaywrightCrawler
#941
Conversation
Does the incognito pages option have any relationship with the cookie handling? Also, a test would be nice 🙂 |
Yes. When we work in basic mode we are working with one common context. In this case, cookies will be strayed between sessions. However, by using |
Can this be a desirable state for anyone?
I sort of think that this should be the default. Do we really need to make it configurable? What does the JS version do? |
It's not the default, because it means no browser cache, so a huge perf cost, when we were testing this, things took literally twice the time to finish because of that. |
So does the JS |
Stores, but when using the basic setup, they are just as flowing between sessions from the Playwright context. |
This is the thing we really need to redesign in next major. IDK how cookies behave, but the more important part there is that because of this, we keep the same proxy in one browser instance with the defaults (so persistent contexts). In other words, sessions rotate per request, but proxies only per browser (we have some limits on how many times a browser instance can be used). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit, otherwise LGTM, but let's wait for @janbuchar's approve as well.
Description
PlaywrightCrawler
. Cookies are now stored in theSession
and set in Playwright Context from theSession
.use_incognito_pages
option forbrowser_launch_options
allowing each new page to be launched in a separate context.Issues