Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum required version of symfony/serializer #374

Closed
wants to merge 1 commit into from

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented Aug 21, 2024

Closes #373

to fix installation on never versions of Drupal core.

Also adjust minimum version requirement for other Symfony packages.
@mxr576
Copy link
Contributor Author

mxr576 commented Aug 21, 2024

Interesting... tests are still broken with 6.4.10, what are we doing wrong in our code? Or there is still in an issue with Symfony Serializer?

@mxr576
Copy link
Contributor Author

mxr576 commented Aug 21, 2024

Somebody should take a look at whether any of these open issues relates to what we experience here...

https://github.com/symfony/symfony/issues?q=is%3Aissue+is%3Aopen+label%3ASerializer

@kedarkhaire
Copy link
Collaborator

Hi @mxr576
We will check it.
Thanks!

@shishir-intelli
Copy link
Collaborator

@mxr576
Thank you for creating this PR,
The fix for test case failing on this PR is resolved here #376
We will merge this and PR 376 together.

@mxr576
Copy link
Contributor Author

mxr576 commented Sep 12, 2024

Thx, I am glad the issue is close be to solved. I only had a couple of seconds to take a look on that PR and left a feedback. Closing this one.

@mxr576 mxr576 closed this Sep 12, 2024
@mxr576 mxr576 deleted the patch-8 branch September 12, 2024 09:14
@kedarkhaire kedarkhaire added this to the 3.0.7 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install 3.0.6 on Drupal 10.3.2 or on any version that requires symfony/serializer:>6.4.6
3 participants