Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed empty array option for CredentialProducts in AppCredential file due to strict Type #398

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

kedarkhaire
Copy link
Collaborator

@kedarkhaire kedarkhaire commented Dec 3, 2024

Fixes #397

In symfony 7, strict return type is expected as new TypeInfo is introduced.

returing stdClass instead of CredentialProduct class.

@kedarkhaire kedarkhaire changed the base branch from 3.x to 4.x December 3, 2024 13:55
@kedarkhaire kedarkhaire marked this pull request as ready for review January 17, 2025 08:14
@kedarkhaire kedarkhaire changed the title Changes for stdClass passed instead of CredentialProductInterface class Changes for CredentialProduct array Jan 17, 2025
@kedarkhaire kedarkhaire added this to the 4.0.0 milestone Jan 17, 2025
@kedarkhaire kedarkhaire changed the title Changes for CredentialProduct array Removed empty array for CredentialProduct in AppCredential file due to strict Type Jan 17, 2025
@kedarkhaire kedarkhaire changed the title Removed empty array for CredentialProduct in AppCredential file due to strict Type Removed empty array option for CredentialProducts in AppCredential file due to strict Type Jan 17, 2025
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit 28b1267 into apigee:4.x Jan 21, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI issue for TypeError for Symfony 7
2 participants