Merge pull request #143 from pysarenko-bohdan/base64url-auth-fix

add base64url encoding for auth header; patch version upgrade
apocas · Jun 3, 2022 · 1213d91 · 1213d91
2 parents 9fd71f5 + 42677a3
commit 1213d91
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/modem.js b/lib/modem.js
@@ -8,7 +8,6 @@ var querystring = require('querystring'),
   debug = require('debug')('modem'),
   utils = require('./utils'),
   util = require('util'),
-  url = require('url'),
   splitca = require('split-ca'),
   isWin = require('os').type() === 'Windows_NT';
 
@@ -165,7 +164,7 @@ Modem.prototype.dial = function (options, callback) {
 
   if (options.authconfig) {
     optionsf.headers['X-Registry-Auth'] = options.authconfig.key || options.authconfig.base64 ||
-      Buffer.from(JSON.stringify(options.authconfig)).toString('base64');
+      Buffer.from(JSON.stringify(options.authconfig)).toString('base64').replace(/\+/g, "-").replace(/\//g, "_");
   }
 
   if (options.registryconfig) {

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "docker-modem",
   "description": "Docker remote API network layer module.",
-  "version": "3.0.3",
+  "version": "3.0.4",
   "author": "Pedro Dias <[email protected]>",
   "maintainers": [
     "apocas <[email protected]>"