bump version to 2.4.0 #96
Conversation
WalkthroughThe pull request includes modifications to the project version in the Changes
Possibly related PRs
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apollo-client/src/test/java/com/ctrip/framework/apollo/monitor/internal/event/ApolloClientMonitorEventPublisherTest.java(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (8)
🔇 Additional comments (1)
apollo-client/src/test/java/com/ctrip/framework/apollo/monitor/internal/event/ApolloClientMonitorEventPublisherTest.java (1)
25-25: LGTM!The import for
@Afterannotation is correctly placed with other JUnit imports.
...com/ctrip/framework/apollo/monitor/internal/event/ApolloClientMonitorEventPublisherTest.java
Show resolved
Hide resolved
nobodyiam
force-pushed
the
2.4.0-release
branch
from
ac92ca0 to
8172f7d
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apollo-client/src/test/java/com/ctrip/framework/apollo/kubernetes/KubernetesManagerTest.java (1)
70-71: Consider standardizing test documentation language.The test methods use Chinese comments for documentation. For consistency with the codebase and better international collaboration, consider translating these to English.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
apollo-client/src/test/java/com/ctrip/framework/apollo/internals/ConfigMonitorInitializerTest.java(2 hunks)apollo-client/src/test/java/com/ctrip/framework/apollo/internals/K8sConfigMapConfigRepositoryTest.java(2 hunks)apollo-client/src/test/java/com/ctrip/framework/apollo/kubernetes/KubernetesManagerTest.java(2 hunks)apollo-client/src/test/java/com/ctrip/framework/apollo/monitor/internal/DefaultConfigMonitorTest.java(2 hunks)apollo-client/src/test/java/com/ctrip/framework/apollo/monitor/internal/event/ApolloClientMonitorEventPublisherTest.java(2 hunks)apollo-client/src/test/java/com/ctrip/framework/apollo/monitor/internal/exporter/DefaultApolloClientMetricsExporterFactoryTest.java(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apollo-client/src/test/java/com/ctrip/framework/apollo/monitor/internal/event/ApolloClientMonitorEventPublisherTest.java
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (8)
🔇 Additional comments (8)
apollo-client/src/test/java/com/ctrip/framework/apollo/monitor/internal/exporter/DefaultApolloClientMetricsExporterFactoryTest.java (1)
52-55: LGTM! Good test hygiene.The addition of the
tearDownmethod follows JUnit best practices by properly cleaning up theMockInjectorafter each test, preventing test pollution.apollo-client/src/test/java/com/ctrip/framework/apollo/internals/ConfigMonitorInitializerTest.java (1)
53-56: LGTM! Consistent test cleanup.The
tearDownmethod implementation matches the pattern used across the test suite, ensuring proper cleanup of mock instances.apollo-client/src/test/java/com/ctrip/framework/apollo/monitor/internal/DefaultConfigMonitorTest.java (2)
63-65: LGTM! Consistent test cleanup.The
tearDownmethod follows the established pattern for proper test isolation.
61-61: Good catch! Fixed the missing brace.Added the missing closing brace in the
setUpmethod.apollo-client/src/test/java/com/ctrip/framework/apollo/internals/K8sConfigMapConfigRepositoryTest.java (2)
85-88: LGTM! Essential cleanup for Kubernetes-related mocks.The addition of the
tearDownmethod is particularly important here as it ensures proper cleanup of Kubernetes-related mock instances, preventing any potential interference between tests involving ConfigMap operations.
Line range hint
1-1: Verify version bump changes.While these test improvements are valuable, I don't see the actual version bump changes in the provided files. Please ensure that the version is properly updated in the relevant configuration files (e.g., pom.xml).
✅ Verification successful
Version bump from 2.3.0 to 2.4.0 is properly implemented
The version bump is correctly reflected in:
- pom.xml:
<revision>2.4.0</revision>- CHANGES.md: Documents the new version Apollo Java 2.4.0
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for version-related changes in pom.xml files echo "Searching for version changes in pom.xml files..." rg -A 1 "<revision>" --type xmlLength of output: 226
Script:
#!/bin/bash # Check git diff for version changes and previous version echo "Checking version changes in PR..." git diff origin/master...HEAD -- '*pom.xml' echo -e "\nChecking previous version..." git show origin/master:pom.xml | rg "<revision>"Length of output: 333
Script:
#!/bin/bash # Search for version-related information in various files echo "Searching for CHANGELOG files..." fd -i changelog echo -e "\nSearching for version numbers and related discussions..." rg -i "2\.4\.0|version bump|upgrade to" --type md --type txt echo -e "\nSearching for version patterns in documentation..." rg -i "version" -A 2 -B 2 --type md --type txtLength of output: 956
apollo-client/src/test/java/com/ctrip/framework/apollo/kubernetes/KubernetesManagerTest.java (2)
26-26: LGTM!The import statement for
org.junit.Afteris correctly placed with other JUnit imports.
64-67: LGTM! Good test hygiene practice.The tearDown method properly resets the MockInjector after each test, preventing test state pollution. This aligns with similar changes across other test classes in this PR.
What's the purpose of this PR
bump version to 2.4.0
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit
tearDown()method to enhance test isolation by resetting theMockInjectorafter each test case in multiple test classes.