-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experiment: keep ObservableQuery initiated from useQuery inactive before first subscription #12285
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7de2c0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 7096a00685a4df971fe061fb |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…efore first subscription
507624d
to
ff3c4bd
Compare
commit: |
size-limit report 📦
|
Triggered by this Discord discussion
Generally, creating a
ObservableQuery
viawatchQuery
is already a side effect and adds the query toQueryManager.queries
- and it will only be removed if it is subscribed and then unsubscribed.There might be a number of edge-case scenarios where that is not the case, so this is an attempt from a different angle to solve this problem.