Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: keep ObservableQuery initiated from useQuery inactive before first subscription #12285

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

phryneas
Copy link
Member

Triggered by this Discord discussion

Generally, creating a ObservableQuery via watchQuery is already a side effect and adds the query to QueryManager.queries - and it will only be removed if it is subscribed and then unsubscribed.

There might be a number of edge-case scenarios where that is not the case, so this is an attempt from a different angle to solve this problem.

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 7de2c0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Jan 21, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 7096a00685a4df971fe061fb

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 7de2c0b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/678f912b97310f0008654bd5
😎 Deploy Preview https://deploy-preview-12285--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phryneas phryneas force-pushed the pr/inactiveBeforeSubscription branch from 507624d to ff3c4bd Compare January 21, 2025 11:32
Copy link

pkg-pr-new bot commented Jan 21, 2025

npm i https://pkg.pr.new/@apollo/client@12285

commit: 7de2c0b

Copy link
Contributor

github-actions bot commented Jan 21, 2025

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.72 KB (+0.15% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.14 KB (+0.14% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.25 KB (+0.16% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.23 KB (+0.14% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.62 KB (+0.14% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.23 KB (+0.34% 🔺)
import { useQuery } from "dist/react/index.js" (production) 4.31 KB (+0.41% 🔺)
import { useLazyQuery } from "dist/react/index.js" 5.72 KB (+0.31% 🔺)
import { useLazyQuery } from "dist/react/index.js" (production) 4.79 KB (+0.37% 🔺)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (0%)

@nikdimm
Copy link

nikdimm commented Jan 21, 2025

@nikdimm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants