Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fragment doc with Codegen Client Preset support #12290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eddeee888
Copy link

This PR updates Apollo fragment masking support doc for Codegen Client Preset.

Related PR with fixes and recommended codegen config to make it work: dotansimha/graphql-code-generator#10268

@apollo-cla
Copy link

@eddeee888: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: c96c8f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 22, 2025

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c96c8f2

@svc-apollo-docs
Copy link

svc-apollo-docs commented Jan 22, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* (developer-tools)/react/(latest)/data/fragments.mdx

Build ID: 35a6a4df00c314ec3a9f4090

URL: https://www.apollographql.com/docs/deploy-preview/35a6a4df00c314ec3a9f4090

@@ -1135,7 +1135,7 @@ const config: CodegenConfig = {
##### With the `client-preset`

<Note>
Support for the `@unmask` directive was introduced with `@graphql-codegen/client-preset` [v4.5.1](https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1732308151614)
Support for the `@unmask` directive was introduced with `@graphql-codegen/client-preset` [v4.6.0](https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1732308151614)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update the version link after the new version is released

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll preapprove it for now. This change looks good. Will get it merged after that version has been released. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants