-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fragment doc with Codegen Client Preset support #12290
base: main
Are you sure you want to change the base?
Update fragment doc with Codegen Client Preset support #12290
Conversation
@eddeee888: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
👷 Deploy request for apollo-client-docs pending review.Visit the deploys page to approve it
|
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removed
Build ID: 35a6a4df00c314ec3a9f4090 URL: https://www.apollographql.com/docs/deploy-preview/35a6a4df00c314ec3a9f4090 |
@@ -1135,7 +1135,7 @@ const config: CodegenConfig = { | |||
##### With the `client-preset` | |||
|
|||
<Note> | |||
Support for the `@unmask` directive was introduced with `@graphql-codegen/client-preset` [v4.5.1](https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1732308151614) | |||
Support for the `@unmask` directive was introduced with `@graphql-codegen/client-preset` [v4.6.0](https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1732308151614) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: update the version link after the new version is released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll preapprove it for now. This change looks good. Will get it merged after that version has been released. Thanks so much!
This PR updates Apollo fragment masking support doc for Codegen Client Preset.
Related PR with fixes and recommended codegen config to make it work: dotansimha/graphql-code-generator#10268