Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apollo-ksp] Rename the ksp annotations #5401

Merged
merged 3 commits into from
Nov 27, 2023
Merged

[apollo-ksp] Rename the ksp annotations #5401

merged 3 commits into from
Nov 27, 2023

Conversation

martinbonnin
Copy link
Contributor

Use @GraphQL prefix consistently for KSP annotations. Frees ApolloAdapter name for other uses.

Also allow to pass name directly to @GraphQLObject and @GraphQLAdapter for more brevity:

@GraphQLObject(name = "Query") 
class RootQuery {
  // ... 
}

@martinbonnin
Fix Optional.getOrElse
a620acc 
it could return the fallback on present "null" values
@martinbonnin
apollo-ksp: rename annotations and add KDoc
794cf4a 
Use `@GraphQL` prefix consistently for KSP annotations.
Frees ApolloAdapter name for other uses
Also allow to pass name directly to `@GraphQLObject` and `@GraphQLAdapter`
@martinbonnin martinbonnin requested a review from BoD as a code owner November 27, 2023 10:28
Base automatically changed from fix-get-or-else to main November 27, 2023 13:55
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 2da1a07
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/65649ffc48e2830008fca989

@martinbonnin martinbonnin merged commit 4a8ea0c into main Nov 27, 2023
7 checks passed
@martinbonnin martinbonnin deleted the rename-ksp-annotations branch November 27, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD