general improvements #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chassing
commented
Feb 14, 2025
chassing
commented
- ⬆️ Python 3.12
- 🚨 fix shellcheck errors
- ✨ hooks: add post_output
- ✨ terraform-provider-sync script
- VARIABLES_TF_JSON_FILE, VARIABLES_TF_FILE env vars
rporres
reviewed
Feb 14, 2025
| @@ -63,16 +66,16 @@ fi | |||
|
|
|||
|
|
|||
| function validate_generate_tf_config() { | |||
| local F_PATH=$(command -v generate-tf-config) | |||
| F_PATH=$(command -v generate-tf-config) | |||
There was a problem hiding this comment.
local variables are good...
Suggested change
| F_PATH=$(command -v generate-tf-config) | |
| local f_path | |
| f_path=$(command -v generate-tf-config) |
| @@ -1,4 +1,5 @@ | |||
| #!/usr/bin/env bash | |||
| # shellcheck disable=SC2155 | |||
There was a problem hiding this comment.
I've had issues with this in the past... it's not a good idea when using set -e. I don't recommend it. I know that it makes a bit clumsy to declare locals or export variables, but it's a good check to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.