Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version pin of typing-extensions #904

Closed
wants to merge 1 commit into from

Conversation

wangkuiyi
Copy link

The pinned version is pretty old. When I am using a modern pydantic, it complains the need of a newer version of typing-extentions.

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pydantic 2.10.1 requires typing-extensions>=4.12.2, but you have typing-extensions 4.11.0 which is incompatible.

@wangkuiyi wangkuiyi requested review from ruomingp, markblee and a team as code owners December 30, 2024 06:40
Copy link
Contributor

@ruomingp ruomingp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Is there an internal PR that passes CI?

@wangkuiyi
Copy link
Author

Yes, @ruomingp . The internal PR 966 passed the CI.

@wangkuiyi
Copy link
Author

I apologize that I couldn't reproduce the issue that trigger me to file this pull request. When I tried to install Axlearn and projects depending on it, I got typing_extensions==4.11.0 that works well with pydantic==2.9.2.

pydantic                       2.9.2
pydantic_core                  2.23.4
typing_extensions              4.11.0

@wangkuiyi wangkuiyi closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants