Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lora input linear adapter output dim. #911

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Update lora input linear adapter output dim. #911

merged 2 commits into from
Jan 15, 2025

Conversation

JianyuWangV
Copy link
Contributor

No description provided.

@JianyuWangV JianyuWangV requested review from ruomingp, markblee and a team as code owners January 8, 2025 22:06
ruomingp
ruomingp reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ruomingp ruomingp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is there a unittes that can be updated?

markblee
markblee reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@markblee markblee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status of the PR?

@JianyuWangV
Copy link
Contributor Author

What's the status of the PR?

Adding tests and will be ready soon.

@JianyuWangV JianyuWangV added this pull request to the merge queue Jan 15, 2025
Merged via the queue into apple:main with commit cfb5336 Jan 15, 2025
6 checks passed
@JianyuWangV JianyuWangV deleted the fix-lora-out-dim branch January 15, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruomingp ruomingp ruomingp approved these changes

@markblee markblee markblee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JianyuWangV @markblee @ruomingp