Add a concurrency + library evolution documentation. #146
+212
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow this is so good! (there is a little section here that we can probably turn into a link/note once this is ready too: ) |
ktoso
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Looks good! It's definitely a huge improvement to have this written down :-)
Cases look right.
I'm wondering if when we do these ABI/Source guides we could adopt a more easy to skim format like...
| Source compatible | ✅ | |
|---|---|---|
| ABI stable | ❌ | Adding ... always changes mangling |
| ... |
below diffs? Just an idea if we want to keep improving this and move it somewhere later on 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds documentation for source and ABI compatibility for concurrency related API changes.