Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MMIO buildable for WASI (exclude ShellCommand.swift) #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MaxDesiatov
Copy link
Member

@MaxDesiatov MaxDesiatov commented Oct 21, 2024

Neither Dispatch nor Process are available on WASI. To make this module buildable, code in ShellCommand.swift needs to be excluded.

Checklist

- [ ] I've updated the documentation if necessary
- [ ] I've added at least one test that validates that my change is working, if appropriate

Neither `Dispatch` nor `Process` are available for WASI. To make this module buildable, code in `ShellCommand.swift` needs to be excluded.
@MaxDesiatov MaxDesiatov requested a review from rauhul as a code owner October 21, 2024 13:33
@rauhul
Copy link
Collaborator

rauhul commented Oct 23, 2024

Aside from the abysmal issue of dispatch on linux crashing all the time, I'd like to make sure we have ci for any new platforms this repo intends to support, what might that look like for wasi?

@MaxDesiatov
Copy link
Member Author

Since there's no 1st-party Swift SDK for WASI, we can't set up a CI for it and support for WASI can only be tested locally.

@rauhul
Copy link
Collaborator

rauhul commented Oct 24, 2024

Since there's no 1st-party Swift SDK for WASI, we can't set up a CI for it and support for WASI can only be tested locally.

how does one test it locally?

@MaxDesiatov
Copy link
Member Author

The only way I know of is to get a Swift SDK from SwiftWasm and build with that.

@rauhul
Copy link
Collaborator

rauhul commented Oct 25, 2024

What SDK content do you expect would be need? the primary MMIO library has no libc dependency, unless I accidentally re-introduced one.

@MaxDesiatov
Copy link
Member Author

IIUC no Swift SDK for WASI content is needed for MMIO per se. But packages built for WASI depending on MMIO would have to build MMIO for WASI too, because currently there can be only one target platform for the whole build graph in SwiftPM.

@rauhul
Copy link
Collaborator

rauhul commented Dec 16, 2024

Since sh is only used in test code I wonder if theres another option that splits MMIOUtils into two modules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants