Add allocation counter tests for isolated EL operations #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
As with the ELF operations before them, the isolated EL operations currently
incur overhead above-and-beyond the overhead of their non-isolated counterparts.
That's not what we want to see. However, before we "fix" them, we need to add
regression testing to confirm our fix actually worked.
Modifications:
- Add isolated variations of all current EL scheduling tests.
- Where isolated methods didn't have alloc counter tests, add new ones
for the non-isolated versions too.
Result:
More tests.
Lukasa
force-pushed
the
cb-alloc-counter-tests-for-isolated-el-operations
branch
from
4eb86aa to
d681296
Compare
glbrntt
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As with the ELF operations before them, the isolated EL operations currently incur overhead above-and-beyond the overhead of their non-isolated counterparts. That's not what we want to see. However, before we "fix" them, we need to add regression testing to confirm our fix actually worked.
Modifications:
Result:
More tests.