Clean up Sendability in Thread and ThreadPool #3081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation Next on my journey of discovery is NIOThread and NIOThreadPool. These are basically fine, but they need some Sendability annotations and a bit of a cleanup. Modifications Add some Sendability Clean up some shutdown logic to avoid semaphores. Result Another step forward to a strict-concurrency safe world.
FranzBusch
approved these changes
Jan 23, 2025
| @@ -74,8 +74,27 @@ private func sysPthread_create( | |||
|
|
|||
| typealias ThreadOpsSystem = ThreadOpsPosix | |||
|
|
|||
| struct PthreadWrapper: @unchecked Sendable { | |||
There was a problem hiding this comment.
Nit: Can't we use our existing UnsafeTransfer for this?
There was a problem hiding this comment.
We could, but in this case I wanted a special-case wrapper that we can see, and aim to remove when it's no longer needed.
|
The API breakages are expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Next on my journey of discovery is NIOThread and NIOThreadPool. These are basically fine, but they need some Sendability annotations and a bit of a cleanup.
Modifications
Add some Sendability
Clean up some shutdown logic to avoid semaphores.
Result
Another step forward to a strict-concurrency safe world.