Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

add a test for getAllTestResults #136

Open
wants to merge 1 commit into
base: universal-sdk
Choose a base branch
from

Conversation

SophieDePaula
Copy link
Contributor

No description provided.

@SophieDePaula SophieDePaula requested a review from amitzur March 17, 2022 15:33
Copy link
Member

@amitzur amitzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the functionality that is tested here is new and not covered by any other test, the goal was to add coverage to delete test results.

So let's keep this test as is, but also delete the test results and verify that they were deleted. (and update the name of the test to reflect it).

Additional notes:

  1. Any reason to do this only for vg? Please add a classic variant as well.
  2. Did you need to save a new baseline for this test? If so, I think it's unnecessary, as this test is not checking the visual output. Please pass false to eyes.close to avoid the need for a baseline here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants