This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Should not fail all by some aborted tests #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coverage-tests.js
Outdated
| @@ -2162,6 +2162,30 @@ test('should return aborted tests in getAllTestResults', { | |||
| }, | |||
| }) | |||
|
|
|||
| test('Should not fail all by some aborted tests', { | |||
There was a problem hiding this comment.
I think we should keep consistency with the naming. We don't have names that start with the capital latter.
There was a problem hiding this comment.
np, it's a 'copy-paste' typo... fixed the original (the one I copied from) and mine
java/overrides.js
Outdated
| @@ -81,4 +81,5 @@ module.exports = { | |||
|
|
|||
| "should use regions padding": {skipEmit: true}, | |||
| "should use regions padding with vg": {skipEmit: true}, | |||
| "Should not fail all by some aborted tests": {skipEmit: true}, | |||
There was a problem hiding this comment.
What is the point of this test if you immediately skip it for everyone? For me, this looks like a fix that doesn't need a new api, so could be tested seamlessly on all of the sdks.
There was a problem hiding this comment.
removed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.