Upgrade to AIP-62 standard #464
Open
+1,391
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
force-pushed
the
aip_62_only
branch
4 times, most recently
from
b81b5f7 to
a79eab7
Compare
0xmaayan
changed the title
0xmaayan
requested review from
kaw2k,
hardsetting and
kent-white
as code owners
0xmaayan
commented
Jan 22, 2025
| } | ||
|
|
||
| // Remove optional duplications in the _all_wallets array | ||
| this._standard_wallets = this._standard_wallets.filter( |
There was a problem hiding this comment.
for some reason, only Petra keeps showing twice on the wallet selector in some cases, so it is needed mostly for it
0xmaayan
commented
Jan 23, 2025
| * | ||
| * @returns AccountAuthenticator | ||
| */ | ||
| async signTransaction( |
There was a problem hiding this comment.
maybe we need to split it into 2 functions, something like signRawTransaction and signTransactionJson
0xmaayan
commented
Jan 23, 2025
| } | ||
| }; | ||
|
|
||
| const signTransaction = async ( |
There was a problem hiding this comment.
we should move to json input arguments format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the wallet adapter to support only the AIP-62 format and compatible wallets.
The AIP-62 standard is a chain-agnostic set of interfaces and conventions designed to enhance how applications interact with injected wallets. See more https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-62.md
By migrating to AIP-62, we can deprecate unmaintained or unused Aptos wallets, ensuring support is provided only for actively developed and functional wallets.
Additionally, dApps will be able to fetch and utilize wallet type information—a feature that has been highly requested by both the community and internal developers, see https://aptos-org.slack.com/archives/C06TWPH09Q9/p1721771598556349)
Live demo https://aptos-labs.github.io/aptos-wallet-adapter/nextjs-example-aip-62/