Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix type mismatch in clinica.iotools.bids_utils #1376

Merged

Conversation

NicolasGensollen
Copy link
Member

Closes #1375

@NicolasGensollen NicolasGensollen marked this pull request as ready for review November 14, 2024 13:45
@NicolasGensollen NicolasGensollen self-assigned this Nov 14, 2024
Copy link
Contributor

@AliceJoubert AliceJoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @NicolasGensollen !

@NicolasGensollen NicolasGensollen marked this pull request as draft November 14, 2024 15:35
@NicolasGensollen
Copy link
Member Author

This is still buggy, changing to draft...

@AliceJoubert
Copy link
Contributor

Don't know if that would help you in this PR but I looked up what a bad line would be. Here is an example :
bad_line = ['618', '1', 'm18', '1', '08/06/2014', ... , '1', '1', 'measured', 'AUSTIN AC CT Brain H19s', '0']. The code is trying to get rid of the two keys 'measured' and 'AUSTIN...' (these are always the same) and replace them with one key '-4'.

@NicolasGensollen NicolasGensollen marked this pull request as ready for review November 21, 2024 10:44
@NicolasGensollen
Copy link
Member Author

Thanks @AliceJoubert
I just wanted to fix the type error described in the linked issue.
I'm assuming the logic is correct. I reverted to draft because the conditional assignment of the lambda functions wasn't working as expected. It should be good now.

@AliceJoubert
Copy link
Contributor

I checked with the latest clinical data from AIBL and it works as it should ! If you want to merge @NicolasGensollen

@NicolasGensollen
Copy link
Member Author

Thanks for the review @AliceJoubert !

@NicolasGensollen NicolasGensollen merged commit 9032855 into aramis-lab:dev Nov 22, 2024
12 of 14 checks passed
@NicolasGensollen NicolasGensollen deleted the fix-type-bug-bids-utils branch November 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PosixPath vs. string type error in bids_utils.py
2 participants