Skip to content

Commit

Permalink
fix: pr feedback changes
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmad-arbisoft committed Feb 10, 2025
1 parent 3bf33b1 commit d3f9dc5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 14 deletions.
16 changes: 4 additions & 12 deletions src/components/Sidebar/sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,29 +7,21 @@ import useSidebar from "@/hooks/useSidebar";
import { MenuItem, MenuStack, SidebarContainer, Text } from "./styled";
import { SidebarProps } from "./types";

const Sidebar = (props: SidebarProps) => {
const { handleSiebarToggle } = props; // Keep this line, we'll fix the usage below
const Sidebar = ({ handleSidebarToggle }: SidebarProps) => {
const { sidebarItems } = useSidebar();
const [selected, setSelected] = useState<string>("");
const [selected, setSelected] = useState("");

const handleClick = (item: string) => {
setSelected(item);
if (handleSiebarToggle) {
handleSiebarToggle();
}
handleSidebarToggle?.();
};

return (
<SidebarContainer>
<MenuStack>
{sidebarItems.map((item) => (
<MenuItem
key={item}
isSelected={item === selected}
onClick={() => handleClick(item)} // Call the new function
>
<MenuItem key={item} isSelected={item === selected} onClick={() => handleClick(item)}>
<Image src="/assets/images/sidebar-item-icon.svg" alt={item} width={18} height={12} />

<Text>{item}</Text>
</MenuItem>
))}
Expand Down
2 changes: 1 addition & 1 deletion src/components/Sidebar/types.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export type SidebarProps = {
handleSiebarToggle: () => void;
handleSidebarToggle?: VoidFunction;
};
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const MainLayoutContainer = ({ children }: TMainLayoutContainer) => {
<MainContainer>
<MainStack>
<SidebarContainer>
<Sidebar handleSiebarToggle={() => {}} />
<Sidebar />
</SidebarContainer>

<ContentContainer>{children}</ContentContainer>
Expand Down

0 comments on commit d3f9dc5

Please sign in to comment.