Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove notistack from project #23

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

arbisoft-qaisarirfan
Copy link

PR Description: Remove notistack from the Project

Summary

This PR removes the notistack package from the project as it is no longer needed. All instances of notistack have been removed, and the notification system has been refactored where necessary.


Changes Implemented

Uninstalled notistack from the project:

npm uninstall notistack

Removed all imports and usage of notistack across the codebase.

Refactored notification logic to use an alternative:

  • Material UI Snackbar

Tested the application to ensure no errors occur due to the removal of notistack.


How to Test

1️⃣ Pull the branch and install dependencies

git pull origin <branch-name>
npm install

2️⃣ Run the application and check notifications

npm start

3️⃣ Verify that there are no missing dependency errors related to notistack.

4️⃣ Ensure notifications work correctly using the new approach.


Impact

  • Removes an unnecessary dependency, reducing bundle size.
  • Ensures a cleaner and more maintainable codebase.
  • Prevents potential compatibility issues with future updates.

Link to the associated Taiga ticket: https://projects.arbisoft.com/project/arbisoft-sessions-portal-20/us/67

Ready for review! 🚀

Copy link

@farhan2742 farhan2742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants