Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoother transition in settings #1628

Merged
merged 15 commits into from
Feb 14, 2025
Merged

Smoother transition in settings #1628

merged 15 commits into from
Feb 14, 2025

Conversation

ManishMadan2882
Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 commented Feb 11, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    • The skeleton will be delayed for atleast 2 seconds to avoid flashing (useLoaderState custom hook)
    • color scheme and animations are uniform in all the loader components
    • Avoiding ternary operators for each loader variant, instead a separate renderMethod is mapped(ease of maintenance)
    • Advanced options drop gently in the Upload
    • Table and inline code blocks are improved in conversation bubble
  • Why was this change needed? (You can also link to an open issue here)
    UI/UX

Copy link

vercel bot commented Feb 11, 2025

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.36%. Comparing base (bafed63) to head (71970a0).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
- Coverage   33.78%   33.36%   -0.42%     
==========================================
  Files          77       77              
  Lines        4067     4127      +60     
==========================================
+ Hits         1374     1377       +3     
- Misses       2693     2750      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 2:46pm

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you!

@dartpain dartpain merged commit 27a933c into arc53:main Feb 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants