Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update memory_addr, use memory_addr::MemoryAddr to bound PagingMetaData::VirtAddr #6

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Update memory_addr, use memory_addr::MemoryAddr to bound PagingMetaData::VirtAddr #6

merged 7 commits into from
Aug 27, 2024

Conversation

aarkegz
Copy link
Contributor

@aarkegz aarkegz commented Aug 18, 2024

No description provided.

@aarkegz aarkegz requested a review from equation314 August 18, 2024 14:20
@aarkegz aarkegz self-assigned this Aug 18, 2024
@aarkegz aarkegz marked this pull request as ready for review August 27, 2024 02:40
@aarkegz aarkegz requested a review from hky1999 August 27, 2024 02:43
hky1999
hky1999 requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@hky1999 hky1999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to modify 'changelog.md', especially mentioning the dep version of memory_addr has to be updated.

@aarkegz
Copy link
Contributor Author

aarkegz commented Aug 27, 2024

I think we need a minor version bump (0.3 -> 0.4) because

  • It introduced an incompatible dependency update. (memory_addr 0.2 -> 0.3)
  • Several previous updates since 0.3.0 are also not backward compatible

@aarkegz
Copy link
Contributor Author

aarkegz commented Aug 27, 2024

You also need to modify 'changelog.md', especially mentioning the dep version of memory_addr has to be updated.

added

@aarkegz aarkegz merged commit 2193fa5 into arceos-org:main Aug 27, 2024
10 checks passed
@aarkegz aarkegz deleted the update_memory_addr branch August 27, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hky1999 hky1999 hky1999 approved these changes

@equation314 equation314 equation314 approved these changes

Assignees

@aarkegz aarkegz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarkegz @equation314 @hky1999