Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fix and improvements #31

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Build fix and improvements #31

merged 3 commits into from
Oct 13, 2024

Conversation

jxy-s
Copy link
Collaborator

@jxy-s jxy-s commented Oct 13, 2024

This PR addresses the build failure on main with GCC 13. It also enables address sanitizer and fixes a leak in vector found by it.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.79%. Comparing base (4340b13) to head (75ac63b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
radiant/detail/VectorOperations.h 60.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   89.84%   89.79%   -0.06%     
==========================================
  Files          17       17              
  Lines        1980     1989       +9     
  Branches      262      263       +1     
==========================================
+ Hits         1779     1786       +7     
  Misses         13       13              
- Partials      188      190       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxy-s jxy-s merged commit b478350 into main Oct 13, 2024
17 checks passed
@jxy-s jxy-s deleted the build-fix branch October 13, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant