Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Fix 1267: early return in runForMultiple if an empty array is passed #1286

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[4.x] Fix 1267: early return in runForMultiple if an empty array is passed #1286

wants to merge 3 commits into from

Conversation

stancl
Copy link
Member

@stancl stancl commented Jan 8, 2025 •
edited
Loading

TODO:

  • Add tests
  • Figure out how to address a case where an empty Traversable is passed

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (f955b38) to head (1b09973).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1286      +/-   ##
============================================
+ Coverage     84.70%   84.74%   +0.03%     
  Complexity     1037     1037              
============================================
  Files           175      175              
  Lines          3047     3048       +1     
============================================
+ Hits           2581     2583       +2     
+ Misses          466      465       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stancl stancl changed the title fix 1267: early return in runForMultiple if an empty array is passed [4.x] fix 1267: early return in runForMultiple if an empty array is passed Jan 8, 2025
@stancl stancl changed the title [4.x] fix 1267: early return in runForMultiple if an empty array is passed [4.x] Fix 1267: early return in runForMultiple if an empty array is passed Jan 8, 2025
@stancl stancl marked this pull request as ready for review January 11, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stancl @lukinovec