Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): rest endpoints #496

Merged
merged 3 commits into from
Nov 2, 2023
Merged

fix(app): rest endpoints #496

merged 3 commits into from
Nov 2, 2023

Conversation

fdymylja
Copy link
Contributor

@fdymylja fdymylja commented Nov 2, 2023

this brings back rest endpoints in the app

@fdymylja fdymylja requested a review from a team as a code owner November 2, 2023 16:41
@fdymylja fdymylja requested a review from spoo-bar November 2, 2023 16:41
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ffde5eb) 69.28% compared to head (d6905f0) 69.38%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   69.28%   69.38%   +0.10%     
==========================================
  Files          70       70              
  Lines        4145     4139       -6     
==========================================
  Hits         2872     2872              
+ Misses       1169     1163       -6     
  Partials      104      104
Files Coverage Δ
app/app_upgrades.go 61.90% <ø> (ø)
app/app.go 91.42% <0.00%> (+0.83%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zanicar
zanicar approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint issues...

@spoo-bar spoo-bar merged commit 3b382eb into main Nov 2, 2023
9 checks passed
@spoo-bar spoo-bar deleted the fd/fix_rest branch November 2, 2023 17:30
spoo-bar added a commit that referenced this pull request Nov 2, 2023
@fdymylja @spoo-bar
fix(app): rest endpoints (#496)
b650d71 
* fix rest

* CHANGELOG.md

* lint fix

---------

Co-authored-by: Spoorthi Satheesha <[email protected]>
@spoo-bar spoo-bar mentioned this pull request Nov 2, 2023
Merged
spoo-bar added a commit that referenced this pull request Nov 2, 2023
@spoo-bar @fdymylja
fix(app): rest endpoints (#497)
75443a6 
* fix(app): rest endpoints (#496)

* fix rest

* CHANGELOG.md

* lint fix

---------

Co-authored-by: Spoorthi Satheesha <[email protected]>

* Update CHANGELOG.md

---------

Co-authored-by: Frojdi Dymylja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanicar zanicar zanicar approved these changes

@spoo-bar spoo-bar Awaiting requested review from spoo-bar spoo-bar is a code owner automatically assigned from archway-network/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fdymylja @zanicar @spoo-bar