feat: implement x/callback module #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding proto for callback * generating proto types
* adding callback module skeleton * lint fix
* adding params types * adding params test * adding param keeper get and set * fix lint
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
- Coverage 65.90% 65.61% -0.30%
==========================================
Files 64 80 +16
Lines 3916 4633 +717
==========================================
+ Hits 2581 3040 +459
- Misses 1207 1436 +229
- Partials 128 157 +29 ☔ View full report in Codecov by Sentry. |
using collections for params
* adding callback state keepers * updating block height stuff to use int64 instead of uint64 * cleanup * adding type validation * using collections * fixing the collection stuff * storing collection schema in keeper --------- Signed-off-by: Spoorthi <[email protected]>
* params() * callbacks() * using dec coin instead of coin * estimateCallbackFees() * linting * refactor the estimate fees endpoint * linting * adding review comments
* adding update params * request callback * merge updates * fixing callback proto * using only native denom for stuff * handling fees when requesting callback * linting * custom error * addressing pr review comments * do auth stuff before token transfer --------- Signed-off-by: Spoorthi <[email protected]>
* executing callbacks in endblocker * adding docs * cleanup * pleasing the linter gods * adding test for callbackmsg string marshal * linter. i hate you * addressing pr review comments * addressing pr review comments
* adding cli query params * adding cli query estimate-callback-fees & callbacks * implementing sdk.Msg interface * adding cli tx request-callback & cancel-callback * lint fixes
* removing callbacks from genesis state * implementing base genesis * implement init and export genesis * exporting callbacks in genesis * exporting callbacks in genesis * linting
* adding helper methods for x/bank * returning fees in cancel callback * handling fees post callback execution * pr review comments addressing
* creating event types * adding event emit helpers * emitting events * fixing merge --------- Signed-off-by: Spoorthi <[email protected]>
* implementing callback module app wiring * adding to upgrade handler * linting * registering msg codecs
* adding callback types test * adding genesis types test * adding SaveCallback tests * adding DeleteCallback tests * adding RequestCallback tests * adding CancelCallback tests * linting * fixing issue when could not save callbacks * adding callback-test * adding tests for abci * adding TestGetCallbacksByHeight * adding TestGetAllCallbacks * adding TestIterateCallbacksByHeight * adding TestCallbacks * implementing TestEstimateCallbackFees * fixing issue with out of gas error txfee refund handling * fixing linting * cleanup * cleanup the test contract * fixing issue with callback params not being considered * linting 😶🌫️
* Create LICENSE * adding spec boilerplate * Update README.md * Update 01_state.md * Update 02_messages.md * Update 03_end_block.md * Update 04_events.md * Update 06_wasm_bindings.md * Update 05_client.md * typo fixes * Update CHANGELOG.md
zanicar
reviewed
Jan 4, 2024
zanicar
reviewed
Jan 4, 2024
zanicar
reviewed
Jan 4, 2024
zanicar
requested changes
Jan 4, 2024
Signed-off-by: Spoorthi <[email protected]>
fdymylja
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #479
RFC: https://github.com/orgs/archway-network/discussions/25
AIP: #477
The implementation spec can be found under x/callback/spec