Skip to content

Commit

Permalink
Fix regression: report size delta size on PR.
Browse files Browse the repository at this point in the history
The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR.
  • Loading branch information
aentinger committed Feb 21, 2024
1 parent eda1b5e commit 8c1b037
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 20 deletions.
21 changes: 19 additions & 2 deletions .github/workflows/compile-examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,15 @@ on:
# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_dispatch
workflow_dispatch:

env:
SKETCHES_REPORTS_PATH: sketches-reports

jobs:
build:
compile:
name: ${{ matrix.board.fqbn }}
runs-on: ubuntu-latest

env:
SKETCHES_REPORTS_PATH: sketches-reports
# Libraries to install for all boards
UNIVERSAL_LIBRARIES: |
# Install the ArduinoModbus library from the local path
Expand Down Expand Up @@ -117,3 +119,18 @@ jobs:
if-no-files-found: error
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
path: ${{ env.SKETCHES_REPORTS_PATH }}

report:
needs: compile
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest

steps:
- name: Download sketches reports artifacts
uses: actions/download-artifact@v4
with:
path: ${{ env.SKETCHES_REPORTS_PATH }}

- uses: arduino/report-size-deltas@v1
with:
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}
18 changes: 0 additions & 18 deletions .github/workflows/report-size-deltas.yml

This file was deleted.

1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.idea/

0 comments on commit 8c1b037

Please sign in to comment.