Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Board non mounting Bosch Accelerometer BMI270 #39

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix for Board non mounting Bosch Accelerometer BMI270 #39

merged 2 commits into from
Nov 4, 2024

Conversation

maidnl
Copy link
Contributor

@maidnl maidnl commented Nov 4, 2024

Some HW revision of the Science Kit rev 2 board does not mount Bosch accelerometer, however the used sensor library (Arduino_BMI270_BMM150) tried to initialize it. Failed initialization lead to a infinite empty loop.

This PR uses a change in the Arduino_BMI270_BMM150 library that allow to select which Bosch sensor are installed (Magnetometer, Accelerometer or both).
The PR selects Magnetometer only.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Memory usage change @ 38b92f5

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ScienceKit/Nano33BLESenseFirmware
flash		 % examples/ScienceKit/Nano33BLESenseFirmware
RAM for global variables		 % examples/ScienceKitR2/Nano33BLESenseFirmware
flash		 % examples/ScienceKitR2/Nano33BLESenseFirmware
RAM for global variables		 % examples/ScienceKit/RP2040ConnectFirmware
flash		 % examples/ScienceKit/RP2040ConnectFirmware
RAM for global variables		 % examples/ScienceKit/PhysicsLabFirmware
flash		 % examples/ScienceKit/PhysicsLabFirmware
RAM for global variables		 %
arduino:mbed_nano:nano33ble 0 0.0 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0
Click for full report CSV 
Board,examples/ScienceKit/Nano33BLESenseFirmware<br>flash,%,examples/ScienceKit/Nano33BLESenseFirmware<br>RAM for global variables,%,examples/ScienceKitR2/Nano33BLESenseFirmware<br>flash,%,examples/ScienceKitR2/Nano33BLESenseFirmware<br>RAM for global variables,%,examples/ScienceKit/RP2040ConnectFirmware<br>flash,%,examples/ScienceKit/RP2040ConnectFirmware<br>RAM for global variables,%,examples/ScienceKit/PhysicsLabFirmware<br>flash,%,examples/ScienceKit/PhysicsLabFirmware<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0
arduino:mbed_nano:nano33ble,,,,,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,,,,,,,,,0,0.0,0,0.0
arduino:samd:mkrwifi1010,,,,,,,,,,,,,0,0.0,0,0.0

per1234
per1234 previously requested changes Nov 4, 2024
View reviewed changes
examples/ScienceKitR2/PhysicsLabFirmware/config.h Outdated Show resolved Hide resolved
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Memory usage change @ d9d02d1

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ScienceKit/Nano33BLESenseFirmware
flash		 % examples/ScienceKit/Nano33BLESenseFirmware
RAM for global variables		 % examples/ScienceKitR2/Nano33BLESenseFirmware
flash		 % examples/ScienceKitR2/Nano33BLESenseFirmware
RAM for global variables		 % examples/ScienceKit/RP2040ConnectFirmware
flash		 % examples/ScienceKit/RP2040ConnectFirmware
RAM for global variables		 % examples/ScienceKit/PhysicsLabFirmware
flash		 % examples/ScienceKit/PhysicsLabFirmware
RAM for global variables		 %
arduino:mbed_nano:nano33ble 0 0.0 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0
Click for full report CSV 
Board,examples/ScienceKit/Nano33BLESenseFirmware<br>flash,%,examples/ScienceKit/Nano33BLESenseFirmware<br>RAM for global variables,%,examples/ScienceKitR2/Nano33BLESenseFirmware<br>flash,%,examples/ScienceKitR2/Nano33BLESenseFirmware<br>RAM for global variables,%,examples/ScienceKit/RP2040ConnectFirmware<br>flash,%,examples/ScienceKit/RP2040ConnectFirmware<br>RAM for global variables,%,examples/ScienceKit/PhysicsLabFirmware<br>flash,%,examples/ScienceKit/PhysicsLabFirmware<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0
arduino:mbed_nano:nano33ble,,,,,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,,,,,,,,,0,0.0,0,0.0
arduino:samd:mkrwifi1010,,,,,,,,,,,,,0,0.0,0,0.0

@facchinm
Copy link
Contributor

facchinm commented Nov 4, 2024

Requires arduino-libraries/Arduino_BMI270_BMM150#47

@per1234 per1234 dismissed their stale review November 4, 2024 13:45

Requested change has been made. Thanks!

@facchinm facchinm merged commit e4e350d into arduino-libraries:master Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 left review comments

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maidnl @facchinm @per1234