Update anthropometric model data format #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in the previous comments the anthropometric data format now details how prepare also mass, inertia and other properties of each body segment.
| [source] | ||
| ---- | ||
| segment_label: | ||
| Name: segment name including side prefix (string, equal to the segment label, can be omitted) |
There was a problem hiding this comment.
I would rather put all subkey in lower case, i.e name instead of Name
| @@ -233,6 +233,40 @@ Use appropriate leading zeros for R and N to ensure proper ordering of files. | |||
|
|
|||
| **File structure**: Set of lines containing key: value. | |||
| For anthropometric measures, the keys should be the ones presented in <<model.adoc#table_body_segment, body segment table>>. | |||
| Each body segment is characterized by its name, mass, length, center of mass and inertia matrix. | |||
There was a problem hiding this comment.
I would relax the sentence a bit, using can be characterized instead of is , so that we do not force all measurements to be provided.
|
If you agree the 2 small adjustments I suggest, I can handle the adjustment and merge. |
|
Ok for both suggestions.
Thanks
M
… Il giorno 29 apr 2021, alle ore 13:59, Anthony Remazeilles ***@***.***> ha scritto:
If you agree the 2 small adjustments I suggest, I can handle the adjustment and merge.
Other than that, I have no prb with this proposal. May I miss any case @alfonsotecnalia <https://github.com/alfonsotecnalia> ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOUR5Q2IOHA4LM4T4DSQC5DTLFCZZANCNFSM43J5J72A>.
--
Informativa sulla Privacy: http://www.unibs.it/node/8155
<http://www.unibs.it/node/8155>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in the previous comments the anthropometric data format now details how prepare also mass, inertia and other properties of each body segment.