sh2: fix recompiler regressions #1760
Merged
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change corrects two regressions introduced by my last change.
1. The purge() call in SH2::Cache::power() was, through a call to
Recompiler::invalidate(), accessing the pool array before it was
allocated.
This purge call was erronous for two reasons:
- It was purging a single line, though it *appears* the intent was
to purge the entire cache.
- According to the SH7604 manual, the cache is not initialized on
reset.
Therefore, I simply removed the call.
2. The size of the recompiler code cache for both of the two SH2s is
now halved to fit within the recently halved fixed code cache
buffer. The SH2 recompiler is good at reusing previously compiled
blocks, so flushes should not be especially common even with this
reduced capacity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects two regressions introduced by my last change.
The purge() call in SH2::Cache::power() was, through a call to Recompiler::invalidate(), accessing the pool array before it was allocated.
This purge call was erronous for two reasons:
to purge the entire cache.
reset.
Therefore, I simply removed the call.
The size of the recompiler code cache for both of the two SH2s is now halved to fit within the recently halved fixed code cache buffer. The SH2 recompiler is good at reusing previously compiled blocks, so flushes should not be especially common even with this reduced capacity.