Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test!: fix cmd module assertion failed #255

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

kurosakishigure
Copy link
Member

@kurosakishigure kurosakishigure commented Jan 11, 2025

Signed-off-by: Shigure Kurosaki [email protected]

Summary of Changes

  1. Fixed 12723616374
  2. Removed some redundant code

Description

  • What is the purpose of this PR?
    • (if applicable)
  • What problem does it solve?
    • (if applicable)
  • Are there any breaking changes or backwards compatibility issues?
    • There is a conflict with the previous test cases
    • Any use of a null path parameter in the cmd module will result in an error

Related Issue

  • Closes #number(if applicable)

Checklist

  • I have read and followed the guidelines in CONTRIBUTING.md
  • I have already updated the related templates accordingly(if applicable)
  • I have written or updated relevant docs(if applicable)
  • I have already updated the related workflows accordingly(if applicable)
  • I have added or updated tests to cover my changes(if applicable)
  • I have already updated the related dev kits accordingly(if applicable)
  • I have reviewed my code for any potential issues

Additional Notes

(if applicable)

@github-actions github-actions bot added the test Add or improve test label Jan 11, 2025
@kurosakishigure kurosakishigure merged commit ed09749 into canary Jan 11, 2025
28 checks passed
@kurosakishigure kurosakishigure deleted the test/fix_cmd_assertion_failed branch January 11, 2025 12:12
@kurosakishigure kurosakishigure changed the title test: fix cmd module assertion failed test!: fix cmd module assertion failed Jan 11, 2025
@kurosakishigure kurosakishigure added breaking Breaking changes perf Improve performance chore Miscellaneous tasks refactor Refactor code and removed perf Improve performance chore Miscellaneous tasks labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes refactor Refactor code test Add or improve test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant