Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLX model support #124

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
0c15804
Initial mlx integration
ZachNagengast Apr 23, 2024
e8e99fb
Merge branch 'main' into mlx-support
ZachNagengast Apr 23, 2024
211c834
Added MLX feature extractor implementation (#129)
jkrukowski May 3, 2024
1bc914d
Merge branch 'main' into mlx-support
ZachNagengast May 15, 2024
6b8aaf7
Merge branch 'mlx-support' of https://github.com/argmaxinc/WhisperKit…
ZachNagengast May 15, 2024
7cc004b
Added MLX Audio Encoder (#139)
jkrukowski May 22, 2024
9748793
Merge branch 'main' into mlx-support
ZachNagengast May 28, 2024
fc6cf9e
Merge branch 'mlx-support' of https://github.com/argmaxinc/WhisperKit…
ZachNagengast May 28, 2024
941b101
Updates for merge
ZachNagengast May 28, 2024
470e227
Allow MLX and CoreML to coexist (#156)
jkrukowski Jun 4, 2024
b88079d
added MLX text decoder (#161)
jkrukowski Jun 12, 2024
c677f0e
Merge branch 'main' into mlx-support
ZachNagengast Jun 15, 2024
ce60492
Fix merge
ZachNagengast Jun 15, 2024
1e12fe2
Cleanup and more tests for MLX (#169)
jkrukowski Jun 19, 2024
674e26b
Merge branch 'main' into mlx-support
ZachNagengast Jun 25, 2024
4d24e43
Formatting
ZachNagengast Jun 28, 2024
b44c2ce
Merge branch 'main' into mlx-support
ZachNagengast Jul 12, 2024
20549e1
Fix merge for makefile function
ZachNagengast Jul 12, 2024
9e9e13a
Skip plugin validation in CI
ZachNagengast Jul 13, 2024
ca46214
Fix tests from merge
ZachNagengast Jul 13, 2024
1615d69
Update model paths
ZachNagengast Jul 14, 2024
d2c6fd0
Merge branch 'main' into mlx-support
ZachNagengast Jul 14, 2024
08eb93e
Fix model downloads
ZachNagengast Jul 14, 2024
5432a8f
Fix HF auth
ZachNagengast Jul 14, 2024
48cf8ff
Fix HF login script
ZachNagengast Jul 14, 2024
b274e2f
Include hf token in download step
ZachNagengast Jul 14, 2024
4b35952
Remove hf login in favor up update model repo permissions
ZachNagengast Jul 14, 2024
a139839
Use scheme from run config
ZachNagengast Jul 14, 2024
d7cf7a6
Use fixed mlx-swift version
ZachNagengast Jul 15, 2024
2ea8426
MLX Cleanup (#187)
jkrukowski Aug 10, 2024
4c495d2
Merge branch 'mlx-support' of ssh://github.com/argmaxinc/WhisperKit i…
ZachNagengast Sep 3, 2024
6023f74
Refactor protocols for app support
ZachNagengast Sep 4, 2024
cc10a23
WIP perf improvements
ZachNagengast Sep 4, 2024
76d14db
Restructure package.swift
ZachNagengast Sep 7, 2024
292cb16
Complete MLXTokenSampling impl
ZachNagengast Sep 7, 2024
649d139
Fix tests
ZachNagengast Sep 7, 2024
e09cc32
Formatting
ZachNagengast Sep 7, 2024
f7a6c09
Merge branch 'main' into mlx-app-support
ZachNagengast Sep 7, 2024
9fff900
Code review
ZachNagengast Sep 10, 2024
ce11d9b
Update to latest mlx version
ZachNagengast Sep 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use scheme from run config
ZachNagengast committed Jul 14, 2024
commit a139839d9b3427256f3428ccd750ceaf80dbcf39
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
@@ -96,5 +96,5 @@ jobs:
if: ${{ matrix.run-config['condition'] == true }}
run: |
set -o pipefail
xcodebuild clean build-for-testing -scheme whisperkit-Package -destination '${{ matrix.run-config['clean-destination'] }}' -skipPackagePluginValidation | xcpretty
xcodebuild test -only-testing WhisperKitTests/UnitTests -scheme whisperkit-Package -destination '${{ matrix.run-config['test-destination'] }}' -skipPackagePluginValidation
xcodebuild clean build-for-testing -scheme ${{ matrix.run-config['scheme'] }} -destination '${{ matrix.run-config['clean-destination'] }}' -skipPackagePluginValidation | xcpretty
xcodebuild test -only-testing WhisperKitTests/UnitTests -scheme ${{ matrix.run-config['scheme'] }} -destination '${{ matrix.run-config['test-destination'] }}' -skipPackagePluginValidation