Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for <macOS 15 build systems #283

Merged
merged 21 commits into from
Dec 21, 2024
Merged

Patch for <macOS 15 build systems #283

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4915574
Prevent units tests from succeeding on error
ZachNagengast Dec 20, 2024
2eff5b0
Use compiler flags for mltensor sampling
ZachNagengast Dec 20, 2024
936e4ed
Add flag for mltensor utils
ZachNagengast Dec 20, 2024
c39f052
Update platform versions for development and pre-release tests workflows
ZachNagengast Dec 20, 2024
f1f5dbe
Differentiate artifact name in unit-tests.yml workflow
ZachNagengast Dec 20, 2024
b43015f
Stop unit tests early if run condition is false
ZachNagengast Dec 20, 2024
13cf628
Fix macos 14 runner ios version
ZachNagengast Dec 20, 2024
9020e30
Use success error code for expected test skipping
ZachNagengast Dec 20, 2024
ac83405
Lower priority of early stopping task, cleanup
ZachNagengast Dec 20, 2024
2a8b95b
Formatting
ZachNagengast Dec 20, 2024
5a5517d
Fix tests, attempt to lower early stopping task priority further
ZachNagengast Dec 20, 2024
87d1720
Fix inverted action run condition logic
ZachNagengast Dec 20, 2024
cf0b880
Use detached lower priority for early stopping to resolve priority in…
ZachNagengast Dec 20, 2024
f052eac
Fix tests
ZachNagengast Dec 20, 2024
cb589e4
Set test priority for early stopping, fix correctness test on macos 14
ZachNagengast Dec 20, 2024
59ef54f
Upgrade unit test task priority
ZachNagengast Dec 20, 2024
f2d3c22
Specify device for older iOS simulators
ZachNagengast Dec 20, 2024
024049c
Fix workflow for ios-device
ZachNagengast Dec 20, 2024
1d3b1f4
Disable ealy stopping test on watchos
ZachNagengast Dec 20, 2024
250ed9d
Set xcode version on CI
ZachNagengast Dec 20, 2024
75bf130
Make sure test simulator is available on runner
ZachNagengast Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,13 @@ jobs:
sleep 15
xcrun simctl list devices
- name: Build and Test - ${{ matrix.run-config['name'] }}
id: test-step
if: ${{ matrix.run-config['condition'] == true }}
continue-on-error: true
run: |
set -o pipefail
xcodebuild clean build-for-testing -scheme whisperkit-Package -destination '${{ matrix.run-config['clean-destination'] }}' | xcpretty
xcodebuild test -only-testing WhisperKitTests/UnitTests -scheme whisperkit-Package -destination '${{ matrix.run-config['test-destination'] }}'

- name: Upload Test Results
if: failure() && steps.test-step.outcome == 'failure'
if: failure()
uses: actions/upload-artifact@v4
with:
name: test-results-${{ matrix.run-config['name'] }}
Expand Down
Loading