Change max to abs for preprocess time
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`normal` result can be negative. if we do `max(t, 0) then we will reduce the variance when the generated value is negative. It is better to use `abs` in this case.
hariharan-devarajan
approved these changes
Oct 30, 2024
zhenghh04
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zhenghh04 and @hariharan-devarajan,
This PR addresses the problem where
random.normalresult can be negative.if we do
max(t, 0)then we will reduce the variance of preprocess time when the generated value is negative.It is better to use
absin this case.At the same time, I add strict comparison to make sure user does not give negative value while specifying
preprocess_timeorpreprocess_time_stdevin the config.