Skip to content

Commit

Permalink
fix(deps): remove incorrectly duplicated peerDeps (#511)
Browse files Browse the repository at this point in the history
- these are all inside of prod `dependencies` already (choose one)

- notably, `antd` had a version mismatch between `dependencies` and `peerDependencies` (v5 vs v4)
  - `dependencies` supersede `peerDependencies` however, so the v5 dep was already used and the v4 dep was extraneous
  - see the [`yarn.lock` file](https://github.com/argoproj/argo-ui/blob/c65a9520366b0c0cf0ac585618d029e60041a94d/yarn.lock#L5124) as evidence, as well as a downstream `yarn.lock`, such as [Argo Workflows's](https://github.com/argoproj/argo-workflows/blob/93914261cff4216561c89c1f5f6123e7ad0d5f61/ui/yarn.lock#L2812)
    - note how this commit has no changes to the `yarn.lock` file either
  - this mismatch did cause install warnings downstream as well, which were impossible to resolve given this mismatch in `argo-ui`'s own deps
    - so those should now be resolved as well

Signed-off-by: Anton Gilgur <[email protected]>
  • Loading branch information
Anton Gilgur authored Feb 13, 2024
1 parent 17d7a8b commit 7613888
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,8 @@
},
"peerDependencies": {
"@types/react": "^16.8.5",
"antd": "^4.16.13",
"moment": "^2.29.1",
"react": "^16.9.3",
"react-dom": "^16.9.3",
"rxjs": "^7.8.1"
"react-dom": "^16.9.3"
},
"devDependencies": {
"@babel/core": "^7.21.3",
Expand Down

0 comments on commit 7613888

Please sign in to comment.