Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(anta.tests): Nicer result failure messages for Logging and security test module #1028

Conversation

geetanjalimanegslab
Copy link
Collaborator

Description

Updated failure messages for following tests

  1. test_logging.py

    1. VerifyLoggingHosts
  2. test_security.py

    1. VerifySSHIPv4Acl
    2. VerifySSHIPv6Acl
    3. VerifyAPIHttpsSSL
    4. VerifyAPIIPv4Acl
    5. VerifyAPIIPv6Acl

Fixes # (issue id) #587

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have updated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #1028 will not alter performance

Comparing geetanjalimanegslab:fix_test_failure_msg_login_security (c664ba2) with main (9c7a81c)

Summary

✅ 22 untouched benchmarks

@vitthalmagadum vitthalmagadum marked this pull request as ready for review February 5, 2025 10:58
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit 5125845 into aristanetworks:main Feb 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants