Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(anta.tests): Nicer result failure messages BFD & Connectivity test module #1029

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Updated failure messages for following tests

  1. test_bfd.py
    1. VerifyBFDPeersRegProtocols

  2. test_connectivity.py
    1. VerifyReachability
    2. VerifyLLDPNeighbors

Fixes #587

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #1029 will not alter performance

Comparing vitthalmagadum:issue_587_connectivity_and_bfd (c14222f) with main (f0ae643)

Summary

✅ 22 untouched benchmarks

Copy link
Collaborator

@geetanjalimanegslab geetanjalimanegslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anta/input_models/connectivity.py Outdated Show resolved Hide resolved
anta/input_models/connectivity.py Outdated Show resolved Hide resolved
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carl-baillargeon carl-baillargeon merged commit 167417a into aristanetworks:main Feb 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have nicer result failure messages
3 participants