refactor(anta.tests): Nicer result failure messages interface(part -1) test module #1045
Conversation
CodSpeed Performance ReportMerging #1045 will not alter performanceComparing Summary
|
geetanjalimanegslab
changed the title
anta/tests/interfaces.py
Outdated
| self.result.is_success() | ||
| else: | ||
| self.result.is_failure(f"The following interfaces have a usage > {self.inputs.threshold}%: {failed_interfaces}") | ||
| self.result.is_failure(f"Interface: {intf} BPS Rate: {bps_rate} - Greater threshold usage - Expected: {self.inputs.threshold}% Actual: {usage}%") |
There was a problem hiding this comment.
| self.result.is_failure(f"Interface: {intf} BPS Rate: {bps_rate} - Greater threshold usage - Expected: {self.inputs.threshold}% Actual: {usage}%") | |
| self.result.is_failure(f"Interface: {intf} BPS Rate: {bps_rate} Threshold: {self.inputs.threshold}% - usage exceeds the threshold - Usage: {usage}%") |
| self.result.is_success() | ||
| else: | ||
| self.result.is_failure(f"The following interface(s) have non-zero error counters: {wrong_interfaces}") | ||
| counters_data = [f"{counter}: {value}" for counter, value in counters.items() if value > 0] |
There was a problem hiding this comment.
Can we use format_data here from tools?
There was a problem hiding this comment.
Hi, @vitthalmagadum , Although we can implement this, it would cause us to lose the original key names because the capitalize() method is applied to each key in the format_data() util. This could make it challenging for the end user to debug, as they might not notice the title case change in the keys.
Example:
format_data({'inErrors': 42, 'outErrors': 10})
output >> Inerrors: 42, Outerrors: 2"
| self.result.is_success() | ||
| else: | ||
| self.result.is_failure(f"The following interfaces have none 0 storm-control drop counters {storm_controlled_interfaces}") | ||
| storm_controlled_interfaces.append(f"{traffic_type}: {traffic_type_dict['drop']}") |
|
Nicer result failure messages Interface test module following testcases are covers.
Description
Fixes #587
Checklist:
pre-commit run)tox -e testenv)