Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.cli): Make CSV output file option mandatory #1052

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Feb 20, 2025

Description

bonus 🎈:

  • precise doc for JSON
  • auto generate docs for some CLI (TBC)

Fixes #1049

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Fix(anta.cli): Make cvs outputfile mandatory fix(anta.cli): Make cvs outputfile mandatory Feb 20, 2025
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #1052 will not alter performance

Comparing gmuloc:issue/1049 (dbf049b) with main (7c9bef4)

Summary

✅ 22 untouched benchmarks

@carl-baillargeon carl-baillargeon changed the title fix(anta.cli): Make cvs outputfile mandatory fix(anta.cli): Make CSV output file option mandatory Feb 20, 2025
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@gmuloc gmuloc merged commit ecce5e5 into aristanetworks:main Feb 21, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(anta.cli): --csv-output should be mandatory
2 participants