Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(anta): Update VerifySnmpContact , VerifySnmpLocation tests to have a more human readable format for the test result failures messages #806

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Updated to have a more human readable format for the test result failures messages

Fixes ##587 (comment)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft August 29, 2024 11:29
Copy link
Collaborator

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitthalmagadum vitthalmagadum marked this pull request as ready for review August 29, 2024 13:28
@vitthalmagadum vitthalmagadum changed the title feat(anta): Update VerifySnmpContact , VerifySnmpLocation tests to have a more human readable format for the test result failures messages refactor(anta): Update VerifySnmpContact , VerifySnmpLocation tests to have a more human readable format for the test result failures messages Sep 2, 2024
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

sonarqubecloud bot commented Sep 4, 2024

@carl-baillargeon carl-baillargeon merged commit abdaea1 into aristanetworks:main Sep 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants