Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta): Refactor VerifyInterfacesStatus test for nicer failure message #899

Merged
merged 7 commits into from
Nov 5, 2024
Merged

refactor(anta): Refactor VerifyInterfacesStatus test for nicer failure message #899

merged 7 commits into from
Nov 5, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

@vitthalmagadum vitthalmagadum commented Oct 28, 2024 •
edited by carl-baillargeon
Loading

Description

Refactor VerifyInterfacesStatus test for nicer failure message

Related to #587

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft October 28, 2024 04:07
@vitthalmagadum vitthalmagadum changed the title feat(refactor): Refactor VerifyInterfacesStatus test for nicer failure message refactor(anta): Refactor VerifyInterfacesStatus test for nicer failure message Oct 28, 2024
@vitthalmagadum vitthalmagadum force-pushed the issue_587_nicer_failure_msgs branch from 4d65a1d to 33fea61 Compare October 28, 2024 04:29
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 28, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #899 will not alter performance

Comparing vitthalmagadum:issue_587_nicer_failure_msgs (4721924) with main (6414404)

Summary

✅ 8 untouched benchmarks

MaheshGSLAB
MaheshGSLAB reviewed Oct 28, 2024
View reviewed changes
anta/tests/interfaces.py Show resolved Hide resolved
anta/tests/interfaces.py Outdated Show resolved Hide resolved
anta/tests/interfaces.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_interfaces.py Outdated Show resolved Hide resolved
@vitthalmagadum vitthalmagadum force-pushed the issue_587_nicer_failure_msgs branch from 709b125 to 2f22a23 Compare October 29, 2024 11:31
@gmuloc
Copy link
Collaborator

gmuloc commented Oct 29, 2024

@vitthalmagadum please fix the Sonarlint issue

@vitthalmagadum vitthalmagadum force-pushed the issue_587_nicer_failure_msgs branch from 2f22a23 to e04bb0f Compare October 30, 2024 05:31
@vitthalmagadum vitthalmagadum marked this pull request as ready for review October 30, 2024 05:37
@vitthalmagadum
Copy link
Collaborator Author

@vitthalmagadum please fix the Sonarlint issue

Fixed. Thanks!!

carl-baillargeon
carl-baillargeon approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmuloc
gmuloc reviewed Oct 31, 2024
View reviewed changes
anta/tests/interfaces.py Outdated Show resolved Hide resolved
anta/tests/interfaces.py Show resolved Hide resolved
tests/units/anta_tests/test_interfaces.py Show resolved Hide resolved
@carl-baillargeon carl-baillargeon mentioned this pull request Nov 5, 2024
Open
32 tasks
@vitthalmagadum vitthalmagadum force-pushed the issue_587_nicer_failure_msgs branch from 8696cdf to 91273f2 Compare November 5, 2024 09:33
@vitthalmagadum vitthalmagadum requested a review from gmuloc November 5, 2024 09:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@carl-baillargeon carl-baillargeon merged commit 206de52 into aristanetworks:main Nov 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@MaheshGSLAB MaheshGSLAB Awaiting requested review from MaheshGSLAB

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: refactor(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitthalmagadum @gmuloc @carl-baillargeon @MaheshGSLAB